Add compile and run interface to kfp based runners #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/fondant/pipeline/runner.py
Outdated
Comment on lines
122
to
124
| self._run(output_path) | ||
| else: | ||
| self._run(input) |
There was a problem hiding this comment.
I think we should pass the experiment_name here as well?
| @@ -92,11 +97,37 @@ def _resolve_imports(self): | |||
| ) | |||
|
|
|||
| def run( | |||
There was a problem hiding this comment.
Can't help but notice that the flow of this method is the same for every runner. Might be worth it to lift it to the base Runner class. Up to you.
There was a problem hiding this comment.
I had the same idea when commuting home, will also make testing a lot easier
src/fondant/pipeline/runner.py
Outdated
| @@ -121,7 +121,7 @@ def run( | |||
| ) | |||
| self._run(output_path) | |||
There was a problem hiding this comment.
Shouldn't it be added here as well? :)
GeorgesLorre
force-pushed
the
feature/align-kfp-based-runners
branch
from
54ba090 to
e4103c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.