Add functionality for pullthrough cache rule creation and URI patching #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @GeorgesLorre, left some comments.
In general probably good to add docstrings with some information.
| def _patch_uri(self, og_uri: str) -> str: | ||
| uri, tag = og_uri.split(":") | ||
|
|
||
| # force pullthrough cache to be used |
There was a problem hiding this comment.
Can you add some more info on how this works? Eg. that it only pulls the manifest.
GeorgesLorre
force-pushed
the
feature/ecr-images
branch
from
4f630e3 to
22791e4
Compare
|
coverage :( |
We could choose to exclude the Sagemaker compilation from coverage analysis since it's not testable. Depends on what you want our coverage metric to represent :) |
RobbeSneyders
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.