Use new data format #667
Merged
Use new data format #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrchtr
requested review from
RobbeSneyders,
GeorgesLorre and
PhilippeMoussalli
There was a problem hiding this comment.
Thanks @mrchtr!
All the test files in `tests/pipeline/examples are shown as newly added. I think this is because you didn't remove the old ones (or at least didn't include this in git).
I would be in favor of choosing better column names. Eg.
images_data->imagecaptions_data->caption
But for me it's fine to include it like this for now. We can change them later.
components/embedding_based_laion_retrieval/fondant_component.yaml
Outdated
Show resolved
Hide resolved
| @@ -238,7 +238,7 @@ def remove_field(self, name: str) -> None: | |||
|
|
|||
| del self._specification["fields"][name] | |||
|
|
|||
| def evolve( # noqa : PLR0912 (too many branches) | |||
| def evolve( # : PLR0912 (too many branches) | |||
There was a problem hiding this comment.
Something happened to the comment here.
Co-authored-by: Robbe Sneyders <[email protected]>
Co-authored-by: Robbe Sneyders <[email protected]>
RobbeSneyders
merged commit 9f057ad
into
feature/redesign-dataset-format-and-interface
3 of 4 checks passed
RobbeSneyders
added a commit
that referenced
this pull request
Nov 24, 2023
This PR applies the usage of the new data format: - fixes all tests - update component specifications and component code - remove subset field usage in `pipeline.py` --------- Co-authored-by: Robbe Sneyders <[email protected]>
RobbeSneyders
added a commit
that referenced
this pull request
Nov 27, 2023
This PR applies the usage of the new data format: - fixes all tests - update component specifications and component code - remove subset field usage in `pipeline.py` --------- Co-authored-by: Robbe Sneyders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the usage of the new data format:
pipeline.py