Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sagemaker runner #664

Merged
merged 9 commits into from
Nov 23, 2023
Merged

Feature/sagemaker runner #664

merged 9 commits into from
Nov 23, 2023

Conversation

GeorgesLorre
Copy link
Collaborator

resolves: #663

@GeorgesLorre GeorgesLorre force-pushed the feature/sagemaker-compiler branch from 53f9e72 to 7018ce2 Compare November 22, 2023 15:27
@RobbeSneyders
Copy link
Member

Thanks @GeorgesLorre! Is there a reason not to implement the interface from #651 yet?

Base automatically changed from feature/sagemaker-compiler to main November 23, 2023 12:02
@GeorgesLorre GeorgesLorre force-pushed the feature/sagemaker-runner branch from bd34345 to 7e925c2 Compare November 23, 2023 15:05
@GeorgesLorre
Copy link
Collaborator Author

Thanks @GeorgesLorre! Is there a reason not to implement the interface from #651 yet?

want to keep changes manageable. It will come in a follow up PR

RobbeSneyders
RobbeSneyders approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks fine to me then!

@GeorgesLorre GeorgesLorre merged commit fe7e036 into main Nov 23, 2023
6 checks passed
@GeorgesLorre GeorgesLorre deleted the feature/sagemaker-runner branch November 23, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbeSneyders RobbeSneyders RobbeSneyders approved these changes

@mrchtr mrchtr Awaiting requested review from mrchtr

@PhilippeMoussalli PhilippeMoussalli Awaiting requested review from PhilippeMoussalli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Sagemaker runner that can submit a sagemaker pipeline and follow up on progress
2 participants
@GeorgesLorre @RobbeSneyders