Refactor component package #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Robbe Sneyders <[email protected]>
Co-authored-by: Robbe Sneyders <[email protected]>
Co-authored-by: Robbe Sneyders <[email protected]>
Co-authored-by: Robbe Sneyders <[email protected]>
Co-authored-by: Robbe Sneyders <[email protected]>
There was a problem hiding this comment.
Thanks @mrchtr!
Just a quick partial review. I'll need to take my time to dive a bit deeper to review with Dask performance in mind.
Co-authored-by: Robbe Sneyders <[email protected]>
Merged
Co-authored-by: Philippe Moussalli <[email protected]>
mrchtr
force-pushed
the
feautre/refactore-component-package
branch
from
46e2219 to
d2182a0
Compare
Base automatically changed from
feature/implement-new-dataset-format
to
feature/redesign-dataset-format-and-interface
November 23, 2023 09:37
|
I merged the base branch into this one so we can review @mrchtr. Please double check that I did it correctly :) |
There was a problem hiding this comment.
Can we keep any changes related to the changed interface out of this PR and in #665? It's a bit hard to keep track otherwise.
mrchtr
force-pushed
the
feautre/refactore-component-package
branch
2 times, most recently
from
734526b to
d2182a0
Compare
RobbeSneyders
approved these changes
Nov 23, 2023
RobbeSneyders
merged commit 3576e3f
into
feature/redesign-dataset-format-and-interface
1 of 5 checks passed
RobbeSneyders
added a commit
that referenced
this pull request
Nov 24, 2023
Refactor component package as part of #643 --------- Co-authored-by: Robbe Sneyders <[email protected]> Co-authored-by: Philippe Moussalli <[email protected]>
RobbeSneyders
added a commit
that referenced
this pull request
Nov 27, 2023
Refactor component package as part of #643 --------- Co-authored-by: Robbe Sneyders <[email protected]> Co-authored-by: Philippe Moussalli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor component package as part of #643