Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Qdrant support #646

Merged
merged 9 commits into from
Nov 21, 2023
Merged

feat: Qdrant support #646

merged 9 commits into from
Nov 21, 2023

Conversation

Anush008
Copy link
Contributor

@Anush008 Anush008 commented Nov 16, 2023

This PR intends to add Qdrant as a supported loading destination.

You can find Qdrant setup instructions here.
https://qdrant.tech/documentation/quick-start/

Copy link
Contributor

@mrchtr mrchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Anush008! Looks good on the first view. Can you add a component test?
For instance you could have a look at the chunk_text component.

Basically, you have to slightly adapt the Dockerfile, and implement your custom test case in the test directory.

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Anush008! Great to have this!

This looks good to me apart from running pre-commit. You can run

pre-commit run --all-files

and it will automatically fix the failing pipeline. Note my comment about the README below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated by our precommit hooks. You can add any custom information you want to add (like the "important" note) to the description field in the fondant_component.yaml file. It supports markdown.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be resolved now.
38acad6

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

FYI, if there's other Qdrant components you think would make sense, we would be happy to have them. Eg. one to query the vector store.

@RobbeSneyders RobbeSneyders merged commit eb27d99 into ml6team:main Nov 21, 2023
6 checks passed
@Anush008 Anush008 deleted the qdrant-load branch November 21, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants