Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component readmes #538

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Update component readmes #538

merged 2 commits into from
Oct 19, 2023

Conversation

RobbeSneyders
Copy link
Member

This should fix the pre-commit pipeline.

Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Robbe! I think later on we can think about removing some of the internal arguments that are either defined in the component spec or used internally #539

@RobbeSneyders
Copy link
Member Author

RobbeSneyders commented Oct 19, 2023

I didn't even notice that they were added 😴

Already fixed.

@RobbeSneyders RobbeSneyders linked an issue Oct 19, 2023 that may be closed by this pull request
@RobbeSneyders RobbeSneyders merged commit 1e6932e into main Oct 19, 2023
4 checks passed
@RobbeSneyders RobbeSneyders deleted the update-component-readmes branch October 19, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove internal arguments from component's README
2 participants