Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fondant build command #527

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Add fondant build command #527

merged 1 commit into from
Oct 18, 2023

Conversation

RobbeSneyders
Copy link
Member

Fixes #249

Please test this on your local machine when reviewing :)

Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Robbe :) Tested it out and it seems to work.

I am not 100% about this but I did notice that it takes slightly longer to build with the docker python SDK compared to the CLI (I might be wrong though). Do you know if there are differences between the two?

Can we also add some tests and docs? can be later to prioritize the CC work but maybe let's add a ticket for it

@RobbeSneyders
Copy link
Member Author

Thanks Robbe :) Tested it out and it seems to work.

Great! I'll ask Jan if he can test on Windows as well :)

I am not 100% about this but I did notice that it takes slightly longer to build with the docker python SDK compared to the CLI (I might be wrong though). Do you know if there are differences between the two?

There should not really be a difference, as they both connect to the docker engine which does the actual building.

Can we also add some tests and docs? can be later to prioritize the CC work but maybe let's add a ticket for it

Sounds good 👍

@RobbeSneyders RobbeSneyders merged commit ec60a36 into main Oct 18, 2023
4 checks passed
@RobbeSneyders RobbeSneyders deleted the feature/fondant-build branch October 18, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a fondant build command
2 participants