Add vertex runner #429
Merged
Add vertex runner #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeMoussalli
approved these changes
Sep 12, 2023
pyproject.toml
Outdated
| @@ -53,13 +53,14 @@ s3fs = { version = ">= 2023.4.0", optional = true } | |||
| adlfs = { version = ">= 2023.4.0", optional = true } | |||
| kfp = { version = "2.0.1", optional = true } | |||
| pandas = { version = ">= 1.3.5", optional = true } | |||
| google-cloud-aiplatform = "^1.32.0" | |||
There was a problem hiding this comment.
Can you add it as optional similar to the above?
There was a problem hiding this comment.
good spot, updated!
src/fondant/runner.py
Outdated
|
|
||
| self.aip = aip | ||
|
|
||
| def __init__(self, project_id: str, project_region: str, service_account: str = ""): |
There was a problem hiding this comment.
Suggested change
| def __init__(self, project_id: str, project_region: str, service_account: str = ""): | |
| def __init__(self, project_id: str, project_region: str, service_account: t.Optional[str]=None): |
src/fondant/runner.py
Outdated
Comment on lines
111
to
114
| if self.service_account: | ||
| job.submit(service_account=self.service_account) | ||
| else: | ||
| job.submit() |
There was a problem hiding this comment.
Suggested change
| if self.service_account: | |
| job.submit(service_account=self.service_account) | |
| else: | |
| job.submit() | |
| job.submit(service_account=self.service_account) |
with the above suggestion, since the service account defined in submit() can be optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adresses: #417