change meta estimation #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| + (dataframe.id.cumsum()).astype(str) | ||
| str(partition_info["number"]) | ||
| + "_" | ||
| + (dataframe.id.cumsum()).astype(str) |
There was a problem hiding this comment.
we set the id as str here. Was there no problem with inferring divisions with this ?
There was a problem hiding this comment.
I think it's mainly an issue if you cast an index that is already an integer to a string (or vice-versa) because you then change the order/sorting from numerical to lexicographical.
This shouldn't be the case here since we're creating a string index from the start. Dask will infer the divisions based on the lexicographical order of the index from the start (and then it should be preserved).
GeorgesLorre
approved these changes
Sep 13, 2023
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
PR that fixes an issue with the load from hub component when setting an index dynamically. Previous implementation relied on estimating the `meta/schema` dynamically but this lead to some errors since sometimes the wrong type was inferred. This PR fixes this issue by reading in the schema from the component spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that fixes an issue with the load from hub component when setting an index dynamically. Previous implementation relied on estimating the
meta/schemadynamically but this lead to some errors since sometimes the wrong type was inferred.This PR fixes this issue by reading in the schema from the component spec