Improve commoncrawl components #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
requested review from
mrchtr,
shayorshay and
PhilippeMoussalli
mrchtr
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Thanks @RobbeSneyders. Lgtm, beside the change regarding metadata writing. Maybe we can exclude this change before we merge the PR.
| @@ -261,7 +261,6 @@ def _create_write_task( | |||
| schema=schema, | |||
| overwrite=False, | |||
| compute=False, | |||
| write_metadata_file=True, | |||
There was a problem hiding this comment.
We should keep in mind to investigate the impact of this change later. In particular to answer the question which impact the writing metadata file affects memory release.
@PhilippeMoussalli do you think this change has an impact on existing components/pipelines?
There was a problem hiding this comment.
I think this was False for a a long time and just recently was introduced. Don't have the full context on why it was removed again. What does it offer?
shayorshay
approved these changes
Sep 12, 2023
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
Improved commoncrawl download components for the license-free image use case.
Merged
RobbeSneyders
added a commit
that referenced
this pull request
Feb 20, 2024
We currently don't preserve the divisions of the data when writing and reading again, which leads to errors when merging datasets with a low and high amount of partitions. This PR enables the writing of a metadata file which should fix this. This was originally introduced in #391, which contains more information, but then later reverted in #403 without a clear reasoning. Let's reactivate it, and if there's a reason to remove it again, let's document it properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the version currently running (check the commits in the specs)