Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing nodepool label #389

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Add missing nodepool label #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/fondant/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,12 +303,13 @@ def kfp_pipeline():
def _set_configuration(self, task, fondant_component_operation):
# Unpack optional specifications
number_of_gpus = fondant_component_operation.number_of_gpus
node_pool_label = fondant_component_operation.node_pool_label
node_pool_name = fondant_component_operation.node_pool_name

# Assign optional specification
if number_of_gpus is not None:
task.set_gpu_limit(number_of_gpus)
if node_pool_name is not None:
task.add_node_selector_constraint("node_pool", node_pool_name)
if node_pool_name is not None and node_pool_label is not None:
task.add_node_selector_constraint(node_pool_label, node_pool_name)

return task
2 changes: 1 addition & 1 deletion tests/example_pipelines/compiled_pipeline/kubeflow_pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ spec:
pipelines.kubeflow.org/pipeline-sdk-type: kfp
name: first-component
nodeSelector:
node_pool: a_node_pool
a_node_pool_label: a_node_pool
outputs:
artifacts:
- name: first-component-output_manifest_path
Expand Down