Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set image pull policy to always #386

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Set image pull policy to always #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/fondant/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,10 @@ def kfp_pipeline():
component_task,
component_op,
)

# Set image pull policy to always
component_task.container.set_image_pull_policy("Always")

# Set the execution order of the component task to be after the previous
# component task.
if previous_component_task is not None:
Expand Down
3 changes: 3 additions & 0 deletions tests/example_pipelines/compiled_pipeline/example_1/kubeflow_pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ spec:
- --output_manifest_path
- /tmp/outputs/output_manifest_path/data
image: example_component:latest
imagePullPolicy: Always
resources:
limits:
nvidia.com/gpu: 1
Expand Down Expand Up @@ -115,6 +116,7 @@ spec:
- --output_manifest_path
- /tmp/outputs/output_manifest_path/data
image: example_component:latest
imagePullPolicy: Always
inputs:
artifacts:
- name: first-component-output_manifest_path
Expand Down Expand Up @@ -209,6 +211,7 @@ spec:
- --output_manifest_path
- /tmp/outputs/output_manifest_path/data
image: example_component:latest
imagePullPolicy: Always
inputs:
artifacts:
- name: second-component-output_manifest_path
Expand Down
2 changes: 2 additions & 0 deletions tests/example_pipelines/compiled_pipeline/example_2/kubeflow_pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ spec:
- --output_manifest_path
- /tmp/outputs/output_manifest_path/data
image: example_component:latest
imagePullPolicy: Always
inputs:
artifacts:
- name: input_manifest_path
Expand Down Expand Up @@ -119,6 +120,7 @@ spec:
- --output_manifest_path
- /tmp/outputs/output_manifest_path/data
image: ghcr.io/ml6team/image_cropping:dev
imagePullPolicy: Always
inputs:
artifacts:
- name: first-component-output_manifest_path
Expand Down
1 change: 1 addition & 0 deletions tests/example_pipelines/compiled_pipeline/kubeflow_pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ spec:
- --output_manifest_path
- /tmp/outputs/output_manifest_path/data
image: example_component:latest
imagePullPolicy: Always
resources:
limits:
nvidia.com/gpu: 1
Expand Down