Bugfix data-explorer images #382
Conversation
PhilippeMoussalli
force-pushed
the
bugfix-dataexplorer-images
branch
from
232b0e9 to
1694d8a
Compare
|
Looks good, are the images rendered decently fast? When did we make the change between binary and object? |
| import streamlit as st | ||
| from data import load_dataframe | ||
| from table import get_image_fields, get_numeric_fields | ||
| from widgets import (build_explorer_table, build_image_explorer, | ||
| build_numeric_analysis_plots, | ||
| build_numeric_analysis_table, build_sidebar) | ||
|
|
||
| dask.config.set({"dataframe.convert-string": False}) |
There was a problem hiding this comment.
what does this do?
There was a problem hiding this comment.
I think it prevents the automatic conversion of bytes to string with Dask
#349
Only tested for 20 images but it was ok. Are there methods to optimize this? Not sure if we every made the switch between the two types (might have happened a while ago). In general, this is the schema that is checked with the manifest: |
|
I'm still getting a lot of issues just running |
I am using the fondant explore with the It does require first building it with I assume this won't be an issue when it's merged to main (if it's part of the CI/CD) |
There was a problem hiding this comment.
Ok, it indeed works when rebuilding it myself. Thanks @PhilippeMoussalli!
PR that fixes the issue with rendering images in the explorer. Images currently have type `binary` and not `object`. This was changed to render them properly. Caveat: not all `binary` types will correspond to images so we will need to implement another logic for image detection but this fix should do for now. Fixed another small bug related to errors in rendering the numerical explorer when no numeric columns are present
PR that fixes the issue with rendering images in the explorer. Images currently have type
binaryand notobject. This was changed to render them properly.Caveat: not all
binarytypes will correspond to images so we will need to implement another logic for image detection but this fix should do for now.Fixed another small bug related to errors in rendering the numerical explorer when no numeric columns are present