-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign base path file structure #373
Merged
+275
−272
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8f19071
Create seperate class for metadata
PhilippeMoussalli eab1f0d
add pipeline name to manifest schema
PhilippeMoussalli a827668
add pipeline name to manifest schema
PhilippeMoussalli 3f03055
Merge branch 'base_path_file_structure' into create_metadata_class
PhilippeMoussalli 1a8762e
reorder base path directory
PhilippeMoussalli 6b61a4f
Merge branch 'main' into create_metadata_class
PhilippeMoussalli 986e3a8
revert back changes to compiler
PhilippeMoussalli c875760
Merge branch 'create_metadata_class' into base_path_file_structure
PhilippeMoussalli f75838a
fix manifest save path
PhilippeMoussalli a44a335
Merge branch 'main' into base_path_file_structure
PhilippeMoussalli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 44 additions & 44 deletions
88
tests/example_specs/evolution_examples/1/output_manifest.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,46 +1,46 @@ | ||
| { | ||
| "metadata": { | ||
| "pipeline_name": "test_pipeline", | ||
| "base_path": "gs://bucket", | ||
| "run_id": "12345", | ||
| "component_id": "example_component" | ||
| }, | ||
| "index": { | ||
| "location": "/index/12345/example_component" | ||
| }, | ||
| "subsets": { | ||
| "images": { | ||
| "location": "/images/12345/example_component", | ||
| "fields": { | ||
| "width": { | ||
| "type": "int32" | ||
| }, | ||
| "height": { | ||
| "type": "int32" | ||
| }, | ||
| "data": { | ||
| "type": "binary" | ||
| } | ||
| "metadata":{ | ||
| "pipeline_name":"test_pipeline", | ||
| "base_path":"gs://bucket", | ||
| "run_id":"12345", | ||
| "component_id":"example_component" | ||
| }, | ||
| "index":{ | ||
| "location":"/test_pipeline/12345/example_component/index" | ||
| }, | ||
| "subsets":{ | ||
| "images":{ | ||
| "location":"/test_pipeline/12345/example_component/images", | ||
| "fields":{ | ||
| "width":{ | ||
| "type":"int32" | ||
| }, | ||
| "height":{ | ||
| "type":"int32" | ||
| }, | ||
| "data":{ | ||
| "type":"binary" | ||
| } | ||
| } | ||
| }, | ||
| "captions":{ | ||
| "location":"/test_pipeline/12345/example_component/captions", | ||
| "fields":{ | ||
| "data":{ | ||
| "type":"binary" | ||
| } | ||
| } | ||
| }, | ||
| "embeddings":{ | ||
| "location":"/test_pipeline/12345/example_component/embeddings", | ||
| "fields":{ | ||
| "data":{ | ||
| "type":"array", | ||
| "items":{ | ||
| "type":"float32" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "captions": { | ||
| "location": "/captions/12345/example_component", | ||
| "fields": { | ||
| "data": { | ||
| "type": "binary" | ||
| } | ||
| } | ||
| }, | ||
| "embeddings": { | ||
| "location": "/embeddings/12345/example_component", | ||
| "fields": { | ||
| "data": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "float32" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
72 changes: 36 additions & 36 deletions
72
tests/example_specs/evolution_examples/2/output_manifest.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,38 @@ | ||
| { | ||
| "metadata": { | ||
| "pipeline_name": "test_pipeline", | ||
| "base_path": "gs://bucket", | ||
| "run_id": "12345", | ||
| "component_id": "example_component" | ||
| }, | ||
| "index": { | ||
| "location": "/index/12345/example_component" | ||
| }, | ||
| "subsets": { | ||
| "images": { | ||
| "location": "/images/12345/example_component", | ||
| "fields": { | ||
| "width": { | ||
| "type": "int32" | ||
| }, | ||
| "height": { | ||
| "type": "int32" | ||
| }, | ||
| "data": { | ||
| "type": "binary" | ||
| } | ||
| "metadata":{ | ||
| "pipeline_name":"test_pipeline", | ||
| "base_path":"gs://bucket", | ||
| "run_id":"12345", | ||
| "component_id":"example_component" | ||
| }, | ||
| "index":{ | ||
| "location":"/test_pipeline/12345/example_component/index" | ||
| }, | ||
| "subsets":{ | ||
| "images":{ | ||
| "location":"/test_pipeline/12345/example_component/images", | ||
| "fields":{ | ||
| "width":{ | ||
| "type":"int32" | ||
| }, | ||
| "height":{ | ||
| "type":"int32" | ||
| }, | ||
| "data":{ | ||
| "type":"binary" | ||
| } | ||
| } | ||
| }, | ||
| "embeddings":{ | ||
| "location":"/test_pipeline/12345/example_component/embeddings", | ||
| "fields":{ | ||
| "data":{ | ||
| "type":"array", | ||
| "items":{ | ||
| "type":"float32" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "embeddings": { | ||
| "location": "/embeddings/12345/example_component", | ||
| "fields": { | ||
| "data": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "float32" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
60 changes: 30 additions & 30 deletions
60
tests/example_specs/evolution_examples/3/output_manifest.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,32 @@ | ||
| { | ||
| "metadata": { | ||
| "pipeline_name": "test_pipeline", | ||
| "base_path": "gs://bucket", | ||
| "run_id": "12345", | ||
| "component_id": "example_component" | ||
| }, | ||
| "index": { | ||
| "location": "/index/12345/example_component" | ||
| }, | ||
| "subsets": { | ||
| "images": { | ||
| "location": "/images/12345/example_component", | ||
| "fields": { | ||
| "data": { | ||
| "type": "binary" | ||
| } | ||
| "metadata":{ | ||
| "pipeline_name":"test_pipeline", | ||
| "base_path":"gs://bucket", | ||
| "run_id":"12345", | ||
| "component_id":"example_component" | ||
| }, | ||
| "index":{ | ||
| "location":"/test_pipeline/12345/example_component/index" | ||
| }, | ||
| "subsets":{ | ||
| "images":{ | ||
| "location":"/test_pipeline/12345/example_component/images", | ||
| "fields":{ | ||
| "data":{ | ||
| "type":"binary" | ||
| } | ||
| } | ||
| }, | ||
| "embeddings":{ | ||
| "location":"/test_pipeline/12345/example_component/embeddings", | ||
| "fields":{ | ||
| "data":{ | ||
| "type":"array", | ||
| "items":{ | ||
| "type":"float32" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "embeddings": { | ||
| "location": "/embeddings/12345/example_component", | ||
| "fields": { | ||
| "data": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "float32" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not the biggest fan of having kubeflow specific code in here. Opened #376 to remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, though I don't see a clear-cut solution for this just yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will vertex have the same issue ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably, ideally we have some control over the format and save path of the artifact.