Create separate class for metadata #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeMoussalli
requested review from
GeorgesLorre and
RobbeSneyders
and removed request for
GeorgesLorre
PhilippeMoussalli
force-pushed
the
create_metadata_class
branch
from
eab1f0d to
a827668
Compare
src/fondant/compiler.py
Outdated
| self, | ||
| pipeline: Pipeline, | ||
| ): | ||
| self.pipeline = pipeline |
There was a problem hiding this comment.
I originally proposed to move the pipeline argument to the compile method, and I still think that's more logical.
Why is the pipeline passed as an initialization argument instead of to the
compilemethod. From a logical perspective, I wouldn't expect a compiler instance to be specific to a single pipeline.
Originally posted by @RobbeSneyders in #194 (comment)
There was a problem hiding this comment.
oh I see, makes sense. I'll revert the changes
src/fondant/compiler.py
Outdated
| path, volume = self._patch_path(base_path=pipeline.base_path) | ||
| run_id = f"{pipeline.name}-{timestamp}" | ||
| metadata = MetaData(run_id=run_id, base_path=path) | ||
| datetime.datetime.now().strftime("%Y%m%d%H%M%S") |
There was a problem hiding this comment.
Is this line doing anything?
There was a problem hiding this comment.
No, it should be removed
GeorgesLorre
approved these changes
Aug 22, 2023
Co-authored-by: Georges Lorré <[email protected]>
RobbeSneyders
approved these changes
Aug 22, 2023
RobbeSneyders
pushed a commit
that referenced
this pull request
Aug 23, 2023
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
PR that creates a metadata class, this will make it easier to implement #368 (was originally part of #325 but decided to break it down to make it easier to review). Few other notable changes: - The `run_id` between both runners has now an identical format (name_timestamp), we no longer need the uid of kfp since it's just used to store the native output artifacts - The `safe_component_name` has been moved from the local runner to the component spec to avoid having to plug it everywhere --------- Co-authored-by: Georges Lorré <[email protected]>
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that creates a metadata class, this will make it easier to implement #368 (was originally part of #325 but decided to break it down to make it easier to review).
Few other notable changes:
run_idbetween both runners has now an identical format (name_timestamp), we no longer need the uid of kfp since it's just used to store the native output artifactssafe_component_namehas been moved from the local runner to the component spec to avoid having to plug it everywhere