-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataComp] Run pipeline at scale #337
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #319 and includes all changes made to run the DataComp pipeline at scale. It's not meant to be merged as it's too big (see below), but enables to reproduce the
UnicodeDecodeError
issue.It includes:
int64
in the schema of Fondantdownload_images
anddetect_text
.This branch also includes 2 variations of the
detect_text
component, namely:detect_text_gpu
: this one replacesonnxruntime
byonnxruntime-gpu
in therequirements.txt
to make sure it can leverage a GPUdetect_text_torch_gpu
: this one leverages plain PyTorch instead of ONNX to run inference.At the moment, both components are hit by the following issue:
when writing image data to the cloud. Weirdly, this works for the
detect_text
(CPU only component).As this branch is too large to be merged, I'll break it down into smaller parts:
dataset_length
argument andset_index
toload_from_hf_hub
[load_from_hf_hub] Add dataset_length, set_index #339download_images
component to the datacomp pipeline: [DataComp] Add download images component #348detect_text
component to the datacomp pipeline: [DataComp] Add T-MARS #374