Bugfix: Data explorer local runner usage #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: NielsRogge <[email protected]>
Co-authored-by: NielsRogge <[email protected]>
Co-authored-by: Robbe Sneyders <[email protected]>
- change docker cmd for running the image on mac M1 - update data explorer docs
RobbeSneyders
approved these changes
Jul 20, 2023
|
Thanks @mrchtr! |
satishjasthi
pushed a commit
to satishjasthi/fondant
that referenced
this pull request
Jul 21, 2023
I have tested `fondant explore` by using local manifest on a M1. Therefore, I ran into some issues. - I updated the data explorer Dockerfile according to this solution proposal (streamlit/streamlit#4842 (comment)) which allows the execution of the streamlit container on a M1 - If a user has not named the local data directory as `artifacts`, the local path can not be resolved, and the data explorer can not load the parquet files. Therefore, I propose keeping the original name of the data directory when mounting it to the Docker container. - Some smaller typo fixes of the data explorer documentation --------- Co-authored-by: NielsRogge <[email protected]> Co-authored-by: Robbe Sneyders <[email protected]>
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
I have tested `fondant explore` by using local manifest on a M1. Therefore, I ran into some issues. - I updated the data explorer Dockerfile according to this solution proposal (streamlit/streamlit#4842 (comment)) which allows the execution of the streamlit container on a M1 - If a user has not named the local data directory as `artifacts`, the local path can not be resolved, and the data explorer can not load the parquet files. Therefore, I propose keeping the original name of the data directory when mounting it to the Docker container. - Some smaller typo fixes of the data explorer documentation --------- Co-authored-by: NielsRogge <[email protected]> Co-authored-by: Robbe Sneyders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested
fondant exploreby using local manifest on a M1. Therefore, I ran into some issues.I updated the data explorer Dockerfile according to this solution proposal (streamlit run fails for containerized v1.10.0 streamlit/streamlit#4842 (comment)) which allows the execution of the streamlit container on a M1
If a user has not named the local data directory as
artifacts, the local path can not be resolved, and the data explorer can not load the parquet files. Therefore, I propose keeping the original name of the data directory when mounting it to the Docker container.Some smaller typo fixes of the data explorer documentation