-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLM pipeline] Add normalize text component #246
[LLM pipeline] Add normalize text component #246
Conversation
@@ -0,0 +1,20 @@ | |||
name: Normalize text. | |||
description: A component that normalizes text. | |||
image: ghcr.io/ml6team/text_normalization:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image: ghcr.io/ml6team/text_normalization:latest | |
image: ghcr.io/ml6team/normalize_text:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in chat, agree with consistent naming, but would actually prefer text_normalization
here as it will group all text components alphabetically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm not necessarily agree on that one, we can group them ourselves in the docs?
Would prefer to have verb + noun for all our components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrchtr! One small change is needed to the logging, otherwise LGTM.
@@ -0,0 +1,20 @@ | |||
name: Normalize text. | |||
description: A component that normalizes text. | |||
image: ghcr.io/ml6team/text_normalization:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in chat, agree with consistent naming, but would actually prefer text_normalization
here as it will group all text components alphabetically.
from fondant.component import PandasTransformComponent | ||
from fondant.logger import configure_logging | ||
|
||
configure_logging() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is outdated, please rebase on / merge with main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrchtr!
Component which applies different text normalization (nfc, lowercasing and regex pattern replacements) This component is needed for the LLM dataset creation pipeline.
Component which applies different text normalization (nfc, lowercasing and regex pattern replacements)
This component is needed for the LLM dataset creation pipeline.