[WIP] Add component type to spec #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will close this for now. Feel free to reopen in the future. |
Merged
PhilippeMoussalli
added a commit
that referenced
this pull request
Jul 6, 2023
PR for running the controlnet pipeline end-to-end on KFP. Some observations when doing the pipeline testing: - Tested with @ChristiaensBert VM and it runs really nice and much faster than the public clip service. - I could not test everything end to end locally since the GPU component are difficult to run locally -> switched to KFP to leverage the GPU VMs - I had to rebuild images using the build and tag images in the `scripts` folder. I think we still need to modify the script to enable only building specified components since it currently default to all components in the `components` directory which might take some time to build - The local runner does not seem to do the subset checking yet and we still need to expand the CLI to be able to use the kfp runner (currently not supported). Although the CLI is really nice overall :) - Pipeline runs fine and writes the dataset to the hub but fails at the end since it expects an output manifest. This can be resolved with this [ticket](#221). We should prioritize this. Notes: - Changed the segmentation to output a segmentation image instead of a segmentation array since that's the output expected for controlnet training Things to do: - Estimate how much the job would cost
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
PR for running the controlnet pipeline end-to-end on KFP. Some observations when doing the pipeline testing: - Tested with @ChristiaensBert VM and it runs really nice and much faster than the public clip service. - I could not test everything end to end locally since the GPU component are difficult to run locally -> switched to KFP to leverage the GPU VMs - I had to rebuild images using the build and tag images in the `scripts` folder. I think we still need to modify the script to enable only building specified components since it currently default to all components in the `components` directory which might take some time to build - The local runner does not seem to do the subset checking yet and we still need to expand the CLI to be able to use the kfp runner (currently not supported). Although the CLI is really nice overall :) - Pipeline runs fine and writes the dataset to the hub but fails at the end since it expects an output manifest. This can be resolved with this [ticket](#221). We should prioritize this. Notes: - Changed the segmentation to output a segmentation image instead of a segmentation array since that's the output expected for controlnet training Things to do: - Estimate how much the job would cost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that implement a component type per spec as discussed here to explicitly define the kubeflow/fondant input and output arguments per component type. This is still work in progress, current changes include adding the necessary changes to the schema and component spec script.
What still needs to be done:
typefield to all the affected components