-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable optional component arguments #201
Merged
Merged
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f7e5dcb
add writer component
PhilippeMoussalli 654a5a6
Merge branch 'main' into write-component-class
PhilippeMoussalli 17c5c7e
modify component spec schema to accept default arguments
PhilippeMoussalli a4e44d2
enable adding default arguments
PhilippeMoussalli 6d2d1ab
test adding default arguments
PhilippeMoussalli af597f8
fixmypy issue
PhilippeMoussalli c90b53b
correct docs
PhilippeMoussalli a8e55d8
update component spec
PhilippeMoussalli 00dfa55
update docs
PhilippeMoussalli 0fa694f
add optional field to schema
PhilippeMoussalli c9f4429
enable defining default arguments
PhilippeMoussalli 5ee3b31
add relevant tests
PhilippeMoussalli 919c21f
Merge branch 'main' into enable-optional-component-arguments
PhilippeMoussalli 66fdb4c
add test file
PhilippeMoussalli 61adc40
bugfix string bool
PhilippeMoussalli 88b4729
change method of defining optionals
PhilippeMoussalli 64614f7
make component spec optional
PhilippeMoussalli 218b8ce
Merge branch 'main' into enable-optional-component-arguments
PhilippeMoussalli 7c7ace7
implement PR feedback
PhilippeMoussalli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,4 +98,4 @@ | |
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it makes sense converting this into a function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or use the
match case
syntax: https://peps.python.org/pep-0622/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore the above
match case
is python 3.10+ and fondant is 3.8+There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback :) I think it's ready to go