Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generic component readme generation #729

Closed
RobbeSneyders opened this issue Dec 18, 2023 · 0 comments · Fixed by #737
Closed

Update generic component readme generation #729

RobbeSneyders opened this issue Dec 18, 2023 · 0 comments · Fixed by #737
Assignees
@PhilippeMoussalli
Labels
Components Implementation of components documentation Improvements or additions to documentation

Comments

@RobbeSneyders
Copy link
Member

The generated README for generic components isn't completely correct, since it doesn't handle additionalProperties. We should update the template so it's clear for users how to use them.
@RobbeSneyders RobbeSneyders added documentation Improvements or additions to documentation Components Implementation of components labels Dec 18, 2023
@PhilippeMoussalli PhilippeMoussalli self-assigned this Dec 19, 2023
@PhilippeMoussalli PhilippeMoussalli mentioned this issue Dec 19, 2023
Merged
@RobbeSneyders RobbeSneyders moved this from Backlog to Validation in Fondant development Dec 20, 2023
PhilippeMoussalli added a commit that referenced this issue Dec 22, 2023
@PhilippeMoussalli
Update generic readme generation (#737)
8f3563a 
Fixes #729
@github-project-automation github-project-automation bot moved this from Validation to Done in Fondant development Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippeMoussalli PhilippeMoussalli

Labels
Components Implementation of components documentation Improvements or additions to documentation
Projects
Fondant development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update generic readme generation ml6team/fondant
2 participants
@RobbeSneyders @PhilippeMoussalli