Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement previous_index #656

Closed
Tracked by #564
mrchtr opened this issue Nov 22, 2023 · 0 comments · Fixed by #668
Closed
Tracked by #564

Implement previous_index #656

mrchtr opened this issue Nov 22, 2023 · 0 comments · Fixed by #668

Comments

@mrchtr
Copy link
Contributor

mrchtr commented Nov 22, 2023 •
edited
Loading

Based on #567 additionalFields can be defined inside the consumes and produces section.
Additional we need a separat keyword to mark index changes (e.g. previous_index)

#653 removed some manifest evolution test cases. We should add new test cases there to test the new logic of additionalFields.
@mrchtr mrchtr mentioned this issue Nov 22, 2023
Closed
@mrchtr mrchtr mentioned this issue Nov 22, 2023
Merged
@RobbeSneyders RobbeSneyders moved this from Backlog to Breakdown in Fondant development Nov 22, 2023
@mrchtr mrchtr moved this from Breakdown to Ready for development in Fondant development Nov 22, 2023
@RobbeSneyders RobbeSneyders mentioned this issue Nov 24, 2023
Merged
@mrchtr mrchtr moved this from Ready for development to In Progress in Fondant development Nov 24, 2023
@mrchtr mrchtr moved this from In Progress to Validation in Fondant development Nov 24, 2023
@mrchtr mrchtr linked a pull request Nov 24, 2023 that will close this issue
Implement previous_index field #668
Merged
RobbeSneyders added a commit that referenced this issue Nov 27, 2023
@RobbeSneyders
Implement previous_index field (#668)
521578f 
#656 

We might want to validate this by checking that the field mentioned in
`previous_index` is also defined in the `consumes` section.
RobbeSneyders added a commit that referenced this issue Nov 27, 2023
@RobbeSneyders
Implement previous_index field (#668)
be8c67b 
#656 

We might want to validate this by checking that the field mentioned in
`previous_index` is also defined in the `consumes` section.
@github-project-automation github-project-automation bot moved this from Validation to Done in Fondant development Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Fondant development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement previous_index field ml6team/fondant
2 participants
@mrchtr @RobbeSneyders