Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Abstract test class and update tests #367

Closed
RobbeSneyders opened this issue Aug 17, 2023 · 1 comment · Fixed by #510
Closed

Remove Abstract test class and update tests #367

RobbeSneyders opened this issue Aug 17, 2023 · 1 comment · Fixed by #510
Assignees
@mrchtr
Labels
CI/CD Related to CI/CD of the repository

Comments

@RobbeSneyders
Copy link
Member

In #335 we decided to no longer use any abstraction for testing as it's straightforward to explicitly call the transform method of a component. We should remove the abstract test class and update the tests that use it.

@mrchtr agree?
@mrchtr
Copy link
Contributor

mrchtr commented Aug 17, 2023

Agreed. In practice, we discovered more limitations than advantages. In the future, it could be useful to offer commonly used methods needed for tests. However, for now, it is hard to estimate how these methods would look.

@RobbeSneyders RobbeSneyders mentioned this issue Aug 29, 2023
Closed
@RobbeSneyders RobbeSneyders added the CI/CD Related to CI/CD of the repository label Aug 29, 2023
@RobbeSneyders RobbeSneyders moved this from Backlog to Ready for development in Fondant development Oct 5, 2023
@mrchtr mrchtr self-assigned this Oct 11, 2023
@mrchtr mrchtr moved this from Ready for development to In Progress in Fondant development Oct 11, 2023
@mrchtr mrchtr mentioned this issue Oct 11, 2023
Merged
RobbeSneyders pushed a commit that referenced this issue Oct 11, 2023
@mrchtr
Remove abstract component test (#510)
a7bbab2 
Removing abstract component test and update image caption component
test.

Resolves #367
@github-project-automation github-project-automation bot moved this from In Progress to Done in Fondant development Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrchtr mrchtr

Labels
CI/CD Related to CI/CD of the repository
Projects
Fondant development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove abstract component test ml6team/fondant
2 participants
@mrchtr @RobbeSneyders