Skip to content

Commit

Permalink
Bugfix basepath (#324)
Browse files Browse the repository at this point in the history
PR to read base path from the manifest instead of the metadata argument
since we're not passing the metadata as an argument to every component
  • Loading branch information
PhilippeMoussalli authored Jul 28, 2023
1 parent f6256c8 commit d38b308
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/fondant/executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,9 @@ def upload_manifest(self, manifest: Manifest, save_path: t.Union[str, Path]):
if is_kubeflow_output:
# Save to the expected base path directory
safe_component_name = self.spec.name.replace(" ", "_").lower()
base_path = self.metadata["base_path"]
save_path_base_path = f"{base_path}/{safe_component_name}/manifest.json"
save_path_base_path = (
f"{manifest.base_path}/{safe_component_name}/manifest.json"
)
Path(save_path_base_path).parent.mkdir(parents=True, exist_ok=True)
manifest.to_file(save_path_base_path)
logger.info(f"Saving output manifest to {save_path_base_path}")
Expand Down

0 comments on commit d38b308

Please sign in to comment.