Fix missing slash manifest evolution (#385)

ml6team · Aug 24, 2023 · 11eeab9 · 11eeab9
1 parent 81cd69f
commit 11eeab9
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/src/fondant/manifest.py b/src/fondant/manifest.py
@@ -305,7 +305,7 @@ def evolve(  # noqa : PLR0912 (too many branches)
                 # Update subset location as this is currently always rewritten
                 evolved_manifest.subsets[subset_name]._specification[
                     "location"
-                ] = f"{self.pipeline_name}/{self.run_id}/{component_id}/{subset_name}"
+                ] = f"/{self.pipeline_name}/{self.run_id}/{component_id}/{subset_name}"
 
             # Subset is not yet in manifest, add it
             else:

diff --git a/tests/example_specs/evolution_examples/4/output_manifest.json b/tests/example_specs/evolution_examples/4/output_manifest.json
@@ -10,7 +10,7 @@
    },
    "subsets":{
       "images":{
-         "location":"test_pipeline/12345/example_component/images",
+         "location":"/test_pipeline/12345/example_component/images",
          "fields":{
             "width":{
                "type":"int32"

diff --git a/tests/example_specs/evolution_examples/5/output_manifest.json b/tests/example_specs/evolution_examples/5/output_manifest.json
@@ -10,7 +10,7 @@
    },
    "subsets":{
       "images":{
-         "location":"test_pipeline/12345/example_component/images",
+         "location":"/test_pipeline/12345/example_component/images",
          "fields":{
             "encoding":{
                "type":"string"

diff --git a/tests/example_specs/evolution_examples/6/output_manifest.json b/tests/example_specs/evolution_examples/6/output_manifest.json
@@ -10,7 +10,7 @@
    },
    "subsets":{
       "images":{
-         "location":"test_pipeline/12345/example_component/images",
+         "location":"/test_pipeline/12345/example_component/images",
          "fields":{
             "encoding":{
                "type":"string"

diff --git a/tests/example_specs/evolution_examples/7/output_manifest.json b/tests/example_specs/evolution_examples/7/output_manifest.json
@@ -10,7 +10,7 @@
    },
    "subsets":{
       "images":{
-         "location":"test_pipeline/12345/example_component/images",
+         "location":"/test_pipeline/12345/example_component/images",
          "fields":{
             "data":{
                "type":"string"

diff --git a/tests/test_manifest_evolution.py b/tests/test_manifest_evolution.py
@@ -46,5 +46,5 @@ def test_component_spec_location_update():
 
     assert (
         evolved_manifest._specification["subsets"]["images"]["location"]
-        == "test_pipeline/12345/example_component/images"
+        == "/test_pipeline/12345/example_component/images"
     )