Added pagination section #34
Conversation
naelrashdeen
requested review from
steffendsommer,
siemensikkema,
cweinberger and
Casperhr
There was a problem hiding this comment.
Thanks Nael, looks good! Just a few suggestions:
I would add the actual pros and cons of both pagination mechanisms.
E.g. mention that Offset pagination does not work well with dynamic content (content is added or removed frequently). Imagine being on a timeline (like Twitter, Facebook) and new posts come in on top while you are in the middle. When you request the next page the pagination will be broken (same content is shown).
Also it might be relevant to mention complexity when it comes to DB queries. Offset pagination usually has a complexity of O(N) while Cursor pagination has O(1).
We should also mention that implementing cursor-based pagination is not trivial and should only be considered where it makes sense :)
| "links": { | ||
| "first": "https://example-test.like.st/api/test?page=1", | ||
| "last": "https://example-test.like.st/api/test?page=1", | ||
| "prev": null, | ||
| "next": null | ||
| }, |
There was a problem hiding this comment.
Just a detail, but I would probably move links inside of meta
Fixes #7