Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errorhandling #27

Merged
merged 5 commits into from
Jul 13, 2020
Merged

Errorhandling #27

merged 5 commits into from
Jul 13, 2020

Conversation

Casperhr
Copy link
Contributor

No description provided.

@Casperhr Casperhr requested a review from steffendsommer March 30, 2020 18:51
@Casperhr Casperhr linked an issue Mar 30, 2020 that may be closed by this pull request
Copy link
Contributor

@steffendsommer steffendsommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor things otherwise LGTM

README.md Outdated Show resolved Hide resolved
- Should be possible to build a solid UI on top, guiding the user what happened, and how to move on

```
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure all indentations are 4 spaces? Then it's aligned with the rest of the code snippets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe its me, but what do you mean here? can you do a example

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the indentations locally.
Will push to this PR once I get access rights from @Casperhr 🙏

README.md Outdated Show resolved Hide resolved
@yashmurty yashmurty self-assigned this Jul 9, 2020
@yashmurty
Copy link
Contributor

@Casperhr @steffendsommer can we merge this PR now? 🙏

@Casperhr Casperhr merged commit 6032c6c into master Jul 13, 2020
@Casperhr Casperhr deleted the feature/error-handling branch July 13, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topic: Error handling
4 participants