-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errorhandling #27
Errorhandling #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor things otherwise LGTM
- Should be possible to build a solid UI on top, guiding the user what happened, and how to move on | ||
|
||
``` | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make sure all indentations are 4 spaces? Then it's aligned with the rest of the code snippets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe its me, but what do you mean here? can you do a example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the indentations locally.
Will push to this PR once I get access rights from @Casperhr 🙏
Co-authored-by: Steffen D. Sommer <[email protected]>
@Casperhr @steffendsommer can we merge this PR now? 🙏 |
No description provided.