Eslint Config

[schinns]

Fixes #14. In reference to conversation with @jchavarri in PR #18:

A lightweight eslint config!

In lib directory run:

$ yarn lint

P.S.- sorry for the misspelled branch name meant to name it js-lint

[jchavarri]

Thanks a lot for this @benschinn !

This is looking great, I wonder if we could add some "globals" for eslint to ignore them: https://eslint.org/docs/user-guide/configuring#specifying-globals

And eslint-disable-line statements in the existing JavaScript files, so we start from a "zero warnings" state and then move on from there? :)

[schinns]

@jchavarri hey thanks for the review! I pushed up some changes that addresses most things I think.

Now getting just one warning from lint. And it might actually be a bug.

It looks like value argument is unused:
https://github.com/jchavarri/rroo/blob/master/lib/React.js#L71

[jchavarri]

This is awesome @benschinn ! There is just a global joo_global_objec that I think could be removed, but I can do it in a few hours. I'll merge this in at that time as well :)

I will also take a look at that unused var, definitely looks like a bug 🐛

Thanks again! 🚀

[schinns]

@jchavarri should we use something like husky for linting on a pre commit hook?

[schinns]

Oops @jchavarri. I misunderstood your comment above and committed the esy.lock directory. should I remove it? 😬

[jchavarri]

should we use something like husky for linting on a pre commit hook?

@benschinn Husky is cool! Although, I would only add it if we run into linting issues pretty often, for now I'd feel inclined to keep things leaner, especially considering we'll have soon CI integration when #4 is done.

I misunderstood your comment above and committed the esy.lock directory. should I remove it?

Ah! yes please 🙏 There's no rush though, I can do it later otherwise :)

[schinns]

Husky is cool! Although, I would only add it if we run into linting issues pretty often, for now I'd feel inclined to keep things leaner, especially considering we'll have soon CI integration when #4 is done.

Sounds good!

Ah! yes please 🙏 There's no rush though, I can do it later otherwise :)

Done! e41bcf8

[jchavarri]

Thanks @benschinn ! ✨