Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add location on errors for invalid key/ref usage on props #118

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

davesnx
Copy link
Member

@davesnx davesnx commented Jan 21, 2022

Added locations on errors related with key and ref used on props.

I didn't add a test's error for those ones, I'm not sure If we want to get a test case for each error message we trigger. Eventually yes, but our system makes adding a ton of files to achieve that. WDYT?

Copy link
Collaborator

@jchavarri jchavarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@davesnx davesnx merged commit ec7bb5f into main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants