Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo #69

Merged
merged 1 commit into from
May 7, 2024
Merged

doc: fix typo #69

merged 1 commit into from
May 7, 2024

Conversation

Sunt-ing
Copy link
Contributor

@Sunt-ing Sunt-ing commented May 7, 2024

No description provided.

jaywonchung
jaywonchung approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@jaywonchung jaywonchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my 😅 Thanks!

@jaywonchung jaywonchung merged commit 2d7ca7a into ml-energy:master May 7, 2024
1 check passed
@Sunt-ing
Copy link
Contributor Author

Sunt-ing commented May 7, 2024 •
edited
Loading

Maybe we can also change the example in https://ml.energy/zeus/reference/monitor/energy/#zeus.monitor.energy.ZeusMonitor to 1) avoid using a global ZeusMonitor variable, 2) provide a dummy training function (e.g., implemented by sleep), so that users can run the demo easily?

@jaywonchung
Copy link
Member

Yeah, that makes sense. I'd be happy to review the PR if you're willing to implement the change.

@Sunt-ing
Copy link
Contributor Author

Sunt-ing commented May 7, 2024

#70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaywonchung jaywonchung jaywonchung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sunt-ing @jaywonchung