Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytorch Fully Sharded Data Parallel (FSDP) Integration #147
base: master
Are you sure you want to change the base?
Pytorch Fully Sharded Data Parallel (FSDP) Integration #147
Changes from 11 commits
f3dcd22
c3559e2
9de0b4f
fc8ac00
f2173b4
0c43ec8
26d940b
af121a3
9956d4a
636c45d
3ab379a
66573ec
2f41596
63f7fe9
ea0f866
08fd4d3
856b48e
4140af5
96b39bb
c0c53ca
0f803cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 265 is now broken, because the previous implementation assumed that
len(zeus_monitor.gpu_indices)
gives the current world size. Let's just switch the defaultoptimum_selector
toMaxSlowdownConstraint(factor=1.1)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we could use
torch.distributed.get_world_size
(and something analogous for jax) by defining a generic framework functionzeus.framework.get_world_size
. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, I wouldn't bother for this one. Now I think
MaxSlowdownConstraint
is a better default; the original one if from 2022.