-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Implement CPU and DRAM monitoring for zeusd
#137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your work! This is a super valuable addition to the Zeus daemon. I've left some comments and questions. Let me know what you think.
…container Co-authored-by: Jae-Won Chung <[email protected]>
Co-authored-by: Jae-Won Chung <[email protected]>
Co-authored-by: Jae-Won Chung <[email protected]>
Co-authored-by: Jae-Won Chung <[email protected]>
I'm getting this compile error with the
Was there a change with Nvml? |
The error indicates a Rust NVML wrapper side issue. If actual NVML ( |
Look at |
zeusd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major! Thanks a lot for the great work! This will be the last round of reviewing.
Co-authored-by: Jae-Won Chung <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolved merge conflict. |
Failing test is unrelated to this PR. Merging, thanks again @wbjin! |
Co-authored-by: Jae-Won Chung <[email protected]>
Additions
Changes
devices/gpu/linux.rs
device_count
method. Changed so that returns 0 if NVML is unavailable or an error occurs. TODO: change method so that it doesn't squash NVML errors that users will have to be aware of.startup.rs
start_cpu_device_tasks
method. CreateCpuManagementTasks
used inmain.rs
. Also addedCpuManagementTasks
toapp_data
instart_server_uds
andstart_server_tcp
methods.main.rs
. Added aCpuManagementTasks
stop_monitoring
method call to stop monitoring tasks.