Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAPL Monitor for monitoring wraparounds for a rapl file #105

Merged
merged 10 commits into from
Aug 11, 2024
Merged

RAPL Monitor for monitoring wraparounds for a rapl file #105

merged 10 commits into from
Aug 11, 2024

Conversation

wbjin
Copy link
Collaborator

@wbjin wbjin commented Aug 1, 2024

A RAPL monitor that tracks the number of times a RAPL counter has wrapped around (reached max value and go back to 0) within the lifetime of a ZeusMonitor object. Very similar to the PowerMonitor and spawns a thread per RAPL file tracked.

@wbjin wbjin requested a review from jaywonchung August 1, 2024 14:53
@jaywonchung jaywonchung linked an issue Aug 1, 2024 that may be closed by this pull request
RAPL energy reading wrap around. #91
Closed
jaywonchung
jaywonchung reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@jaywonchung jaywonchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think it should work well. I left some high-level comments.

zeus/device/cpu/rapl.py Outdated Show resolved Hide resolved
zeus/monitor/rapl.py Outdated Show resolved Hide resolved
zeus/monitor/rapl.py Outdated Show resolved Hide resolved
jaywonchung
jaywonchung reviewed Aug 10, 2024
View reviewed changes
Copy link
Member

@jaywonchung jaywonchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_rapl.py looks good to me! Nice and clean way to testing.

tests/device/cpu/test_rapl.py Outdated Show resolved Hide resolved
tests/device/cpu/test_rapl.py Outdated Show resolved Hide resolved
@wbjin wbjin requested a review from jaywonchung August 11, 2024 17:48
jaywonchung
jaywonchung approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@jaywonchung jaywonchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good to go. Just left a few style nitpicks and quick questions. Thanks!

zeus/device/cpu/rapl.py Outdated Show resolved Hide resolved
zeus/device/cpu/rapl.py Show resolved Hide resolved
zeus/device/cpu/rapl.py Show resolved Hide resolved
zeus/device/cpu/rapl.py Outdated Show resolved Hide resolved
zeus/device/cpu/rapl.py Outdated Show resolved Hide resolved
zeus/device/cpu/rapl.py Outdated Show resolved Hide resolved
@jaywonchung jaywonchung merged commit 71af89c into master Aug 11, 2024
3 checks passed
@jaywonchung jaywonchung deleted the rapl-monitor branch August 11, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaywonchung jaywonchung jaywonchung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RAPL energy reading wrap around.
2 participants
@wbjin @jaywonchung