fix: make new arch work on iOS #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 2, 2024
|
Looking forward to this one. Thanks for fixing it! |
|
Nice! Really need this |
|
Looks great |
|
Awesome. Thank you for the contribution. @WoLewicki i think i missed the adjustment due to xcode build erros i had. But will test it out asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR making the library work on
iOSwith new arch enabled. For some reason,exportsfield makes the codegen oniOSomit this library. Also,RNHapticFeedbackSpec.his a generated file and it should not be included as a separate one. cc @mkuczera could you elaborate why was it done like that?