Fix uninitialized memory for skin resourceID

Closes surge-synthesizer#4594 Also limit the rangge of mouse drag on multiswitch so that it doesn't start showing nothing.
mkruselj · May 24, 2021 · 2cda76a · 2cda76a
1 parent 6d2d609
commit 2cda76a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/gui/CScalableBitmap.h b/src/gui/CScalableBitmap.h
@@ -54,7 +54,7 @@ class CScalableBitmap : public VSTGUI::CBitmap
     */
     void setExtraScaleFactor(int a) { extraScaleFactor = a; }
 
-    int resourceID;
+    int resourceID = -1;
     std::string fname;
 
   private:

diff --git a/src/gui/widgets/MultiSwitch.cpp b/src/gui/widgets/MultiSwitch.cpp
@@ -97,7 +97,7 @@ void MultiSwitch::mouseDrag(const juce::MouseEvent &event)
     {
         int sel = coordinateToSelection(event.x, event.y);
         hoverSelection = sel;
-        setValue((float)sel / (rows * columns - 1));
+        setValue(limit_range((float)sel / (rows * columns - 1), 0.f, 1.f));
         notifyValueChanged();
     }
 }