Add flag for centring mouse when activating window (with tests) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the shellcheck defaults have changed over the past couple years. Let's just disable shellcheck on jumpapp for now, since so many of the rules are failing.
The previous tests were well written, however they were testing helper functions directly and the integration between that function and the rest of the script didn't appear to be tested. I wasn't initially sure if I was going to break something by moving where the `head` call was being made, so I re-wrote the tests to give me more confidence in the change.
I was actually quite surprised that bash -eq can compare hex strings.
Having not looked at the code for a while, I was confused why we were returning both get_most_recently_focused_window and get_next_window. I think moving up the active window check to the same function and adding a comment makes it a little clearer why we're (potentially) doing both.
After mulling it over, I think "center" is a better mnemonic for this operation than "mouse". I would go with "-c" but it's already in use. My secondary motivation is that a different -m functionality has already been requested in #11. It hasn't been implemented yet, but I could see it being implemented some day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension on #29. See that PR for discussion.