Relocate maven extensions #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maven was fixed in apache/maven#94 to only search the target pom's directory structure for .mvn when passing -f to indicate a specific pom file. Unfortunately that breaks logic in ruby-maven intended to temporarily copy the .mvn/extensions.xml file to the current directory to enable Polyglot Ruby poms. This in turn breaks jar-dependencies when running with newer ruby-maven-libs at the root of the filesystem, for reasons described in jruby/jruby#7059: jruby/jruby#7059 (comment) This is a possible workaround, by putting the extension config in the same dir as the files we want to treat as Polyglot Ruby pom scripts. It does not fix the underlying problem with ruby-maven.
headius
force-pushed
the
relocate_maven_extensions
branch
from
63d748c
to
679ddff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven was fixed in apache/maven#94 to only search the target pom's directory structure for .mvn when passing -f to indicate a specific pom file. Unfortunately that breaks logic in ruby-maven intended to temporarily copy the .mvn/extensions.xml file to the current directory to enable Polyglot Ruby poms. This in turn breaks jar-dependencies when running with newer ruby-maven-libs at the root of the filesystem, for reasons described in jruby/jruby#7059:
jruby/jruby#7059 (comment)
This is a possible workaround, by putting the extension config in the same dir as the files we want to treat as Polyglot Ruby pom scripts. It does not fix the underlying problem with ruby-maven.