Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue 101 - much better perfomance #103

Merged
merged 1 commit into from
Aug 6, 2014
Merged

Conversation

Kurtas
Copy link
Contributor

@Kurtas Kurtas commented Aug 6, 2014

This is fix for issue described here #101
Performance is much better.
See this video for an explanation http://www.paulirish.com/2011/dom-html5-css3-performance/

I'm not javascript expert, but you can also try another tips from this video how to avoid "reflows"

This is fix for issue described here mkoryak#101
Performance is much better.
See this video for an explanation http://www.paulirish.com/2011/dom-html5-css3-performance/

I'm not javascript expert, but you can also try another tips from this video how to avoid "reflows"
@Kurtas
Copy link
Contributor Author

Kurtas commented Aug 6, 2014

BigTable test with this fix 734ms, original version 1620ms ....

@mkoryak
Copy link
Owner

mkoryak commented Aug 6, 2014

This is awesome! Can you update your pull request and change new Array() to [] so:

var width = [];

@mkoryak
Copy link
Owner

mkoryak commented Aug 6, 2014

actually scratch that - I need to regenerate dist anyway, so ill just do it. Thanks for this pull request

mkoryak added a commit that referenced this pull request Aug 6, 2014
Fix for Issue 101 - much better perfomance
@mkoryak mkoryak merged commit 47503de into mkoryak:master Aug 6, 2014
@Kurtas
Copy link
Contributor Author

Kurtas commented Aug 6, 2014

Hi, thanks for regeneration of dist. How is it with CDN? It seems that there is still old version.

PS: I'm not satisfied still with speed, now is much better but I think that it could be better.
I will try play with profiler when I will be have a time :)

@mkoryak
Copy link
Owner

mkoryak commented Aug 6, 2014

If you need it on the CDN then I will need to cut a new version.

@Kurtas
Copy link
Contributor Author

Kurtas commented Aug 6, 2014

Ok, now it is not necessary, I will use local copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants