fix for #86 - hidden TRs no longer used in header height calculation

mkoryak · Jun 30, 2014 · 493b999 · 493b999
1 parent 7b43acc
commit 493b999
Show file tree

Hide file tree

Showing 8 changed files with 1,437 additions and 7 deletions.
diff --git a/dist/jquery.floatThead-slim.js b/dist/jquery.floatThead-slim.js
@@ -279,7 +279,7 @@
 
       function setHeaderHeight(){
         var headerHeight = 0;
-        $header.find("tr").each(function(){
+        $header.find("tr:visible").each(function(){
           headerHeight += $(this).outerHeight(true);
         });
         $sizerRow.outerHeight(headerHeight);

diff --git a/dist/jquery.floatThead-slim.min.js b/dist/jquery.floatThead-slim.min.js
diff --git a/dist/jquery.floatThead.js b/dist/jquery.floatThead.js
@@ -279,7 +279,7 @@
 
       function setHeaderHeight(){
         var headerHeight = 0;
-        $header.find("tr").each(function(){
+        $header.find("tr:visible").each(function(){
           headerHeight += $(this).outerHeight(true);
         });
         $sizerRow.outerHeight(headerHeight);

diff --git a/dist/jquery.floatThead.min.js b/dist/jquery.floatThead.min.js
diff --git a/jquery.floatThead.js b/jquery.floatThead.js
@@ -279,7 +279,7 @@
 
       function setHeaderHeight(){
         var headerHeight = 0;
-        $header.find("tr").each(function(){
+        $header.find("tr:visible").each(function(){
           headerHeight += $(this).outerHeight(true);
         });
         $sizerRow.outerHeight(headerHeight);

diff --git a/package.json b/package.json
@@ -20,12 +20,15 @@
   },
   "homepage": "https://github.com/mkoryak/floatThead",
   "dependencies": {
+    "cheerio": "~0.13.1",
+    "grunt-bg-shell": "~2.3.1",
+    "grunt-contrib-clean": "^0.5.0",
+    "grunt-contrib-concat": "^0.4.0",
+    "grunt-contrib-copy": "^0.5.0",
     "grunt-contrib-uglify": "~0.2.7",
     "grunt-contrib-watch": "~0.5.3",
     "grunt-jekyll": "~0.4.1",
     "grunt-text-replace": "~0.3.10",
-    "grunt-bg-shell": "~2.3.1",
-    "cheerio": "~0.13.1",
     "request": "~2.34.0"
   }
 }
diff --git a/tests.html b/tests.html
@@ -21,5 +21,6 @@ <h1>Tests</h1>
         <li><a href="{{ site.base_url }}/tests/issue-79/">Issue 79</a></li>
         <li><a href="{{ site.base_url }}/tests/issue-82/">Issue 82</a></li>
         <li><a href="{{ site.base_url }}/tests/issue-84/">Issue 84</a></li>
+        <li><a href="{{ site.base_url }}/tests/issue-86/">Issue 86</a></li>
     </ul>
 </div>