-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in version 7.6.0 when base class name has more than one level of nesting #121
Labels
Comments
1 task
mr-cal
added a commit
to canonical/craft-parts
that referenced
this issue
Jan 23, 2024
See mkorpela/overrides#121 Signed-off-by: Callahan Kovacs <[email protected]> Co-authored-by: Alex Lowe <[email protected]>
mr-cal
added a commit
to canonical/craft-parts
that referenced
this issue
Jan 23, 2024
See mkorpela/overrides#121 Signed-off-by: Callahan Kovacs <[email protected]> Co-authored-by: Alex Lowe <[email protected]>
Thank you for the report! |
lengau
added a commit
to canonical/craft-parts
that referenced
this issue
Jan 24, 2024
See mkorpela/overrides#121 Signed-off-by: Callahan Kovacs <[email protected]> Co-authored-by: Alex Lowe <[email protected]>
Can reproduce and added the case to main branch. Thank you again. I'll work on this asap also contributions are much appreciated. |
Regression fixed in 7.7.0. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this issue
Jan 31, 2024
https://build.opensuse.org/request/show/1142842 by user dirkmueller + anag+factory - update to 7.7.0: * Fixing mkorpela/overrides#121
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this issue
Feb 7, 2024
https://build.opensuse.org/request/show/1142842 by user dirkmueller + anag+factory - update to 7.7.0: * Fixing mkorpela/overrides#121
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this issue
Feb 7, 2024
https://build.opensuse.org/request/show/1142842 by user dirkmueller + anag+factory - update to 7.7.0: * Fixing mkorpela/overrides#121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
Release 7.6.0 has broken code where the base class is qualified by several parent classes or modules:
NOTE: it works fine with one single level of qualification (e.g.
some_module.SomeClass
orOuter.InnerClass
)This was working fine with version 7.5.0, but is failing with version 7.6.0 with error "No super class method found" (tested with python 3.9 .7 and 3.11.3 with same error, on Linux).
The regression comes from this change (diff -213/+218 of overrides/overrides.py in changeset 444a7a5): if I comment both checks on
extends
, I get back the previous behavior. However, that change was probably done for a reason, and I don't master bytecode disassembly so I can't really propose a fix...It's easy to work around (see below), but not trivial to figure out what's wrong! If you can have a look at it, it would be great!
Thanks in advance,
Rémi
NOTE: Possible workarounds corresponding to previous snippet:
The text was updated successfully, but these errors were encountered: