-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build wheel files for Python 3.11 #1115
Build wheel files for Python 3.11 #1115
Conversation
Fixes: mkleehammer#1110 Update .github/workflows/ubuntu_build.yml to use cibuildwheel v2.11.2 Add 3.11 references to appveyor.yml and setup.py
I see that there are a number of deprecation warnings in the workflow output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for putting this PR together, @gordthompson !
I notice we're getting deprecation warnings from the runner ("Node.js 12 actions are deprecated" and "The set-output command is deprecated and will be disabled soon"), but I'm fairly sure we can get rid of those by upgrading the runner actions from version 2 to version 3. See lines 152 and 155 of .github/workflows/ubuntu_build.yml. Is it worth trying version 3 of "actions/checkout" and "actions/setup-python" to see if that removes the deprecation warnings?
appveyor.yml
Outdated
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 | ||
PYTHON_HOME: "C:\\Python311" | ||
|
||
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 | ||
PYTHON_HOME: "C:\\Python311-x64" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appveyor is always a bit slower to release the latest Python version than Github, etc. Python 3.11 is not yet available on Appveyor, hence the Appveyor (Windows) tests for Python3.11 are failing. Either we'll have to wait until Appveyor releases Python 3.11 in their windows images, or we'll have to delete these lines for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the Appveyor ticket for Python 3.11, currently available on Ubuntu but not on Windows yet:
appveyor/ci#3844
Still seeing "The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Gord. Thanks again.
Fixes: #1110
Update .github/workflows/ubuntu_build.yml to use
cibuildwheel v2.11.2
Add 3.11 references to appveyor.yml and setup.py