fix count(::BitArray; dims) (JuliaLang#39149)

Not sure why this worked before JuliaLang#37461, perhaps JuliaLang#9498?
mkitti · Jan 8, 2021 · ca07546 · ca07546
1 parent 438f9cb
commit ca07546
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/base/bitarray.jl b/base/bitarray.jl
@@ -1394,7 +1394,7 @@ function bitcount(Bc::Vector{UInt64}; init::T=0) where {T}
     return n
 end
 
-count(B::BitArray; init=0) = bitcount(B.chunks; init)
+_count(::typeof(identity), B::BitArray, ::Colon, init) = bitcount(B.chunks; init)
 
 function unsafe_bitfindnext(Bc::Vector{UInt64}, start::Int)
     chunk_start = _div64(start-1)+1

diff --git a/test/bitarray.jl b/test/bitarray.jl
@@ -1221,6 +1221,7 @@ timesofar("datamove")
     end
 
     @test count(trues(2, 2), init=0x03) === 0x07
+    @test count(trues(2, 2, 2), dims=2) == fill(2, 2, 1, 2)
 end
 
 timesofar("find")
-Original file line number
+Diff line change
@@ Expand Up / @@ -1221,6 +1221,7 @@ timesofar("datamove") @@
         end
         @test count(trues(2, 2), init=0x03) === 0x07
+        @test count(trues(2, 2, 2), dims=2) == fill(2, 2, 1, 2)
     end
     timesofar("find")
@@ Expand Down @@