Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: signature with string not properly rendered as of version 1.12.0 #191

Closed
gautierronan opened this issue Oct 14, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@gautierronan
Copy link

Hi, as of version 1.12.0, it seems that our function signatures that include strings are not properly rendered anymore.

For instance, instead of:

wigner(
    state: ArrayLike,
    *,
    ax: Axes | None = None,
    xmax: float = 5.0,
    ymax: float | None = None,
    vmax: float = 2 / jnp.pi,
    npixels: int = 101,
    cmap: str = "dq",                # bug here
    interpolation: str = "bilinear", # and here
    colorbar: bool = True,
    cross: bool = False,
    clear: bool = False
)

we have:

wigner(state: ArrayLike, *, ax: Axes | None = None, xmax: float = 5.0, ymax: float | None = None, vmax: float = 2 / jnp.pi, npixels: int = 101, cmap: str = 'dq', interpolation: str = 'bilinear', colorbar: bool = True, cross: bool = False, clear: bool = False)

(see the example live on our library documentation, here)

It seems that this bug is somehow related to the use of single quotation marks instead of doubles? I'm not sure whether this is a bug arising from our side, of from the side of mkdocstrings-python. Thanks!

@pawamoy
Copy link
Member

pawamoy commented Oct 14, 2024

Hi @gautierronan, thanks for the report. It's probably a bug on our end, some HTML that isn't properly escaped. Working on it!

@pawamoy pawamoy added bug Something isn't working and removed unconfirmed This bug was not reproduced yet labels Oct 14, 2024
pawamoy added a commit that referenced this issue Oct 14, 2024
@pawamoy
Copy link
Member

pawamoy commented Oct 14, 2024

Fixed in v1.12.1 🙂

@pawamoy pawamoy closed this as completed Oct 14, 2024
@gautierronan
Copy link
Author

Thanks @pawamoy for the (very!) quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants