refactor: Improve expressions #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expressions are now proper objects, not just recursive lists of strings and names. This increases robustness for checking if an expression is a tuple, an iterator, etc., and when getting the n-th item of tuples, etc. This will also make it easier to write powerful and robust Griffe extensions. Breaking changes: - `griffe.expressions.Name` was removed - `griffe.expressions.Expression` was removed - mkdocstrings-python 1.2.1 templates won't work with the new expressions
pawamoy
force-pushed
the
better-expressions
branch
from
a1b2094
to
b5d30c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expressions are now proper objects, not just recursive lists of strings and names. This increases robustness for checking if an expression is a tuple, an iterator, etc., and when getting the n-th item of tuples, etc.
This will also make it easier to write powerful and robust Griffe extensions.
Breaking changes:
griffe.expressions.Namewas removedgriffe.expressions.Expressionwas removedwith the new expressions