Change response tag 'server' to 'source' in traefik input plugin (inf…

…luxdata#4413)
mkboudreau · Oct 3, 2018 · 0615ea8 · 0615ea8
1 parent 5647b12
commit 0615ea8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/plugins/inputs/traefik/README.md b/plugins/inputs/traefik/README.md
@@ -55,7 +55,7 @@ Configuration with additional measurements for each status code encountered:
 ### Tags:
 
 - All measurements have the following tags:
-    - **server**
+    - **source**
 
 - `traefik_status_codes` measurement have the following additional tags:
     - **status_code**
@@ -80,8 +80,8 @@ SELECT difference(last("count")) FROM "traefik_status_codes" WHERE time > now()
 
 ./telegraf -config telegraf.conf -input-filter traefik -test
 	
-> traefik,server=http://localhost:8080,instance=prod,host=My-MacBook-Pro.local status_code_302=27117i,status_code_307=4i,status_code_400=1011i,status_code_404=812i,status_code_401=1i,total_response_time_sec=83381.956659941,total_count=1222527i,uptime_sec=1387245.424820805,unixtime=1518039391i,status_code_500=34i,status_code_504=1206i,status_code_503=1i,status_code_301=3i,average_response_time_sec=0.068204593,status_code_502=715i,status_code_304=559007i,status_code_200=632616i,health_response_time_sec=0.061906656 1518039391000000000
+> traefik,source=http://localhost:8080,instance=prod,host=My-MacBook-Pro.local status_code_302=27117i,status_code_307=4i,status_code_400=1011i,status_code_404=812i,status_code_401=1i,total_response_time_sec=83381.956659941,total_count=1222527i,uptime_sec=1387245.424820805,unixtime=1518039391i,status_code_500=34i,status_code_504=1206i,status_code_503=1i,status_code_301=3i,average_response_time_sec=0.068204593,status_code_502=715i,status_code_304=559007i,status_code_200=632616i,health_response_time_sec=0.061906656 1518039391000000000
 
-> traefik_status_codes,server=http://localhost:8080,status_code=304,instance=prod total_count=1588167i,uptime_sec=1629993.771782303,unixtime=1518624416i,count=752109i,health_response_time_sec=1.0587943 1518624424000000000
+> traefik_status_codes,source=http://localhost:8080,status_code=304,instance=prod total_count=1588167i,uptime_sec=1629993.771782303,unixtime=1518624416i,count=752109i,health_response_time_sec=1.0587943 1518624424000000000
 
 ```
diff --git a/plugins/inputs/traefik/traefik.go b/plugins/inputs/traefik/traefik.go
@@ -149,7 +149,7 @@ func (t *Traefik) Gather(acc telegraf.Accumulator) error {
 	json.NewDecoder(resp.Body).Decode(&healthData)
 	t.lastRequestTiming = time.Since(start).Seconds()
 
-	tags := map[string]string{"server": t.Address}
+	tags := map[string]string{"source": t.Address}
 	fields := map[string]interface{}{"health_response_time_sec": t.lastRequestTiming}
 
 	t.submitPrimaryMeasurement(acc, healthData, tags, fields)

diff --git a/plugins/inputs/traefik/traefik_test.go b/plugins/inputs/traefik/traefik_test.go
@@ -29,7 +29,7 @@ func TestGatherPrimaryHealthCheck(t *testing.T) {
 	defer server.Close()
 
 	traefik := &Traefik{
-		Address: server.URL,
+		Address:                      server.URL,
 		IncludeStatusCodeMeasurement: false,
 	}
 	var acc testutil.Accumulator
@@ -50,7 +50,7 @@ func TestGatherStatusCodes(t *testing.T) {
 	defer server.Close()
 
 	traefik := &Traefik{
-		Address: server.URL,
+		Address:                      server.URL,
 		IncludeStatusCodeMeasurement: true,
 	}
 	var acc testutil.Accumulator
@@ -68,10 +68,10 @@ func TestGatherStatusCodes(t *testing.T) {
 	assert.False(t, acc.HasField("traefik_status_codes", "status_code_400"), "should not have status_code_* fields")
 	acc.AssertContainsTaggedFields(t, "traefik_status_codes",
 		expected200Fields,
-		map[string]string{"status_code": "200", "server": server.URL})
+		map[string]string{"status_code": "200", "source": server.URL})
 	acc.AssertContainsTaggedFields(t, "traefik_status_codes",
 		expected404Fields,
-		map[string]string{"status_code": "404", "server": server.URL})
+		map[string]string{"status_code": "404", "source": server.URL})
 }
 
 func TestHTTPSGatherHealthCheckIntegration(t *testing.T) {