Merge clap-rs#3014

3014: fix(app): Propogate color r=pksunkara a=epage Co-authored-by: Ed Page <[email protected]>
mkayaalp · Nov 13, 2021 · ca3e14c · ca3e14c
2 parents 4b70a6e + a2c3b14
commit ca3e14c
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 21 deletions.
diff --git a/src/build/app/mod.rs b/src/build/app/mod.rs
@@ -314,6 +314,28 @@ impl<'help> App<'help> {
         self.settings.is_set(s) || self.g_settings.is_set(s)
     }
 
+    /// Should we color the output?
+    #[inline]
+    pub fn get_color(&self) -> ColorChoice {
+        debug!("App::color: Color setting...");
+
+        if cfg!(feature = "color") {
+            #[allow(deprecated)]
+            if self.is_set(AppSettings::ColorNever) {
+                debug!("Never");
+                ColorChoice::Never
+            } else if self.is_set(AppSettings::ColorAlways) {
+                debug!("Always");
+                ColorChoice::Always
+            } else {
+                debug!("Auto");
+                ColorChoice::Auto
+            }
+        } else {
+            ColorChoice::Never
+        }
+    }
+
     /// Returns `true` if this `App` has subcommands.
     #[inline]
     pub fn has_subcommands(&self) -> bool {
@@ -1001,9 +1023,9 @@ impl<'help> App<'help> {
     pub fn color(self, color: ColorChoice) -> Self {
         #[allow(deprecated)]
         match color {
-            ColorChoice::Auto => self.setting(AppSettings::ColorAuto),
-            ColorChoice::Always => self.setting(AppSettings::ColorAlways),
-            ColorChoice::Never => self.setting(AppSettings::ColorNever),
+            ColorChoice::Auto => self.global_setting(AppSettings::ColorAuto),
+            ColorChoice::Always => self.global_setting(AppSettings::ColorAlways),
+            ColorChoice::Never => self.global_setting(AppSettings::ColorNever),
         }
     }
 
@@ -2759,24 +2781,6 @@ impl<'help> App<'help> {
         self.args.args().find(|a| a.id == *arg_id)
     }
 
-    #[inline]
-    // Should we color the output?
-    pub(crate) fn get_color(&self) -> ColorChoice {
-        debug!("App::color: Color setting...");
-
-        #[allow(deprecated)]
-        if self.is_set(AppSettings::ColorNever) {
-            debug!("Never");
-            ColorChoice::Never
-        } else if self.is_set(AppSettings::ColorAlways) {
-            debug!("Always");
-            ColorChoice::Always
-        } else {
-            debug!("Auto");
-            ColorChoice::Auto
-        }
-    }
-
     #[inline]
     pub(crate) fn contains_short(&self, s: char) -> bool {
         assert!(

diff --git a/tests/app_settings.rs b/tests/app_settings.rs
@@ -1216,3 +1216,16 @@ fn no_auto_version_mut_arg() {
     assert!(result.is_ok());
     assert!(result.unwrap().is_present("version"));
 }
+
+#[test]
+#[cfg(feature = "color")]
+fn color_is_global() {
+    let mut app = App::new("myprog")
+        .color(clap::ColorChoice::Never)
+        .subcommand(App::new("foo"));
+    app._build_all();
+    assert_eq!(app.get_color(), clap::ColorChoice::Never);
+
+    let sub = app.get_subcommands().collect::<Vec<_>>()[0];
+    assert_eq!(sub.get_color(), clap::ColorChoice::Never);
+}