Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ParamDef copy for the code injection #366

Merged
merged 6 commits into from
Jul 2, 2021
Merged

Implement ParamDef copy for the code injection #366

merged 6 commits into from
Jul 2, 2021

Conversation

oSumAtrIX
Copy link

No description provided.

@AppVeyorBot
Copy link

✅ Build ConfuserEx 797 completed (commit cebb302b3a by @oSumAtrIX)

mkaring
mkaring requested changes Jun 17, 2021
View reviewed changes
Copy link
Owner

@mkaring mkaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this oversight cause an error? As far as I am aware, none of the runtime code that is injected requires these to be present.

Confuser.Core/Helpers/InjectHelper.cs Outdated Show resolved Hide resolved
@AppVeyorBot
Copy link

✅ Build ConfuserEx 798 completed (commit 0366160ad8 by @oSumAtrIX)

@AppVeyorBot
Copy link

✅ Build ConfuserEx 799 completed (commit e81b3a49fa by @oSumAtrIX)

@oSumAtrIX oSumAtrIX requested a review from mkaring June 18, 2021 17:56
@AppVeyorBot
Copy link

✅ Build ConfuserEx 800 completed (commit 7bccaebd4b by @oSumAtrIX)

oSumAtrIX
oSumAtrIX commented Jun 18, 2021
View reviewed changes
Copy link
Author

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix idention style

Confuser.Core/Helpers/InjectHelper.cs Outdated Show resolved Hide resolved
@AppVeyorBot
Copy link

✅ Build ConfuserEx 801 completed (commit 7b5ac7aa53 by @oSumAtrIX)

@mkaring
Copy link
Owner

mkaring commented Jun 19, 2021

Nice try fixing that complex method warning. 😉 The method is still too long for Codefactor to like it.

I noticed that the bracket style of your code doesn't line up with the rest of the code. Opening brackets are usually on the same line. For that not to happen, I got a .editorconfig setup in the project. I'm curious why that one isn't working for you.

@mkaring mkaring added the enhancement New feature or request label Jun 19, 2021
@mkaring mkaring added this to the 1.6 milestone Jun 19, 2021
@mkaring mkaring merged commit 0c65d32 into mkaring:master Jul 2, 2021
@oSumAtrIX oSumAtrIX deleted the patch-1 branch October 22, 2021 02:04
@mkaring mkaring changed the title Implement ParamDef copy Implement ParamDef copy for the code injection Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElektroKill ElektroKill ElektroKill requested changes

@mkaring mkaring mkaring approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
4 participants
@oSumAtrIX @AppVeyorBot @mkaring @ElektroKill