Skip to content

Commit

Permalink
RVC: Fix conformance (project-chip#30600)
Browse files Browse the repository at this point in the history
- admin commissioning doesn't have the BCW feature, but had the
  command on - turned off command
- Identify cluster revision is now 4. It already included the
  v4 attribute, it was just the revision that was incorrect.
  • Loading branch information
cecille authored Nov 24, 2023
1 parent ac1536d commit b5dfe72
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
8 changes: 1 addition & 7 deletions examples/rvc-app/rvc-common/rvc-app.matter
Original file line number Diff line number Diff line change
Expand Up @@ -664,12 +664,7 @@ server cluster AdministratorCommissioning = 60 {
octet_string<32> salt = 4;
}

request struct OpenBasicCommissioningWindowRequest {
int16u commissioningTimeout = 0;
}

timed command access(invoke: administer) OpenCommissioningWindow(OpenCommissioningWindowRequest): DefaultSuccess = 0;
timed command access(invoke: administer) OpenBasicCommissioningWindow(OpenBasicCommissioningWindowRequest): DefaultSuccess = 1;
timed command access(invoke: administer) RevokeCommissioning(): DefaultSuccess = 2;
}

Expand Down Expand Up @@ -1162,7 +1157,6 @@ endpoint 0 {
ram attribute clusterRevision default = 0x0001;

handle command OpenCommissioningWindow;
handle command OpenBasicCommissioningWindow;
handle command RevokeCommissioning;
}

Expand Down Expand Up @@ -1218,7 +1212,7 @@ endpoint 1 {
callback attribute eventList;
callback attribute attributeList default = 0;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 2;
ram attribute clusterRevision default = 4;

handle command Identify;
handle command TriggerEffect;
Expand Down
10 changes: 1 addition & 9 deletions examples/rvc-app/rvc-common/rvc-app.zap
Original file line number Diff line number Diff line change
Expand Up @@ -1426,14 +1426,6 @@
"isIncoming": 1,
"isEnabled": 1
},
{
"name": "OpenBasicCommissioningWindow",
"code": 1,
"mfgCode": null,
"source": "client",
"isIncoming": 1,
"isEnabled": 1
},
{
"name": "RevokeCommissioning",
"code": 2,
Expand Down Expand Up @@ -2095,7 +2087,7 @@
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "2",
"defaultValue": "4",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
Expand Down

0 comments on commit b5dfe72

Please sign in to comment.