Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
  • Loading branch information
mkardous-silabs and tcarmelveilleux authored Oct 5, 2023
1 parent cb7d49f commit a058e99
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/messaging/ExchangeContext.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -702,8 +702,8 @@ bool ExchangeContext::ShouldPeerBeActive()
if (!IsInitiator())
return true;

// If we create an Ephemeral Exchange, it was just to generate a StandaloneAck
// Since we are sending an ack, we know the peer is active
// If we create an Ephemeral Exchange, it was just to generate a StandaloneAck.
// Since we are sending an ack, we know the peer is active.
if (IsEphemeralExchange())
return true;

Expand Down
2 changes: 1 addition & 1 deletion src/messaging/ExchangeContext.h
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ class DLL_EXPORT ExchangeContext : public ReliableMessageContext,
* The first message of the exchange set as the initiator should never have the ShouldPeerBeActive flag to true.
* The API should only called after receiving a message from the peer and after calling the WillSendMessage API.
* The next message sent will then use the active retransmission time out.
* The flag is set to false each time we receive the response from our peer (receiver).
* The flag is reset to false each time we receive the response from our peer (receiver).
* As such, the API needs to be called each time we send another message over the exchange.
*
* The API call is not mandatory for the communication to be successful.
Expand Down

0 comments on commit a058e99

Please sign in to comment.